New providers API #357
Merged
New providers API #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want Provider.features to always be iterable, so let's add a new flag to represent None
Adds a try block when dynamically importing the providers python modules. In the future we might want to include optional providers that only work when some dependency is met, for example some offline providers could not satisfy its deps in a arm machine. In the future we probably will want to expose failing providers in the UI.
helper functions Update bing and google provider to make use of it.
base provider Also adds the lang_aliases dict prop that providers can overwrite to define their own mapping to Dialect/CLDR's lang codes making it more scalable. We still keep the LANG_ALIASES cosnt in the define module to keep a well know mapping of lang codes provided by Dialect.
rafaelmardojai
commented
Nov 17, 2023
This method will probaly come handy in scenarios like DeepL where "en" lang can't be translated to "en-US" nor "en-GB", so extra logic for comparison can be added by the provider.
|
New providers API is done I think, it's really flexible and extendable in the future. |
mufeedali
approved these changes
Dec 11, 2023
|
I've committed fixes for the two issues I did find. Code looks great! As this is a pretty huge change, we may still need more testing as it stays in main. Especially maybe the search provider, which I can't test right now as I'm on Plasma. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.