Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data test prop to sharing dialog #1515

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

flaminic
Copy link
Contributor

@flaminic flaminic commented Jun 5, 2024

Needed for DHIS2-17276


Description

Allow sharing dialog modal to have a data test prop

@flaminic flaminic requested a review from a team as a code owner June 5, 2024 15:29
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1515--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 5, 2024 15:33 Inactive
Copy link

cypress bot commented Jun 5, 2024

Passing run #3419 ↗︎

0 584 0 0 Flakiness 0

Details:

feat: add data test prop to sharing dialog
Project: ui Commit: 5a1d81d769
Status: Passed Duration: 07:51 💡
Started: Jun 5, 2024 3:35 PM Ended: Jun 5, 2024 3:43 PM

Review all test suite changes for PR #1515 ↗︎

@flaminic flaminic merged commit 1ae38d9 into master Jun 6, 2024
15 checks passed
@flaminic flaminic deleted the add-test-id-to-sharing-dialog branch June 6, 2024 07:34
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants