Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement split-button accessibility #1512

Closed
wants to merge 3 commits into from

Conversation

Chisomchima
Copy link
Contributor

@Chisomchima Chisomchima commented Jun 3, 2024

Implements LIBS-611


Description

improved accessibility by adding tabIndexes on both buttons and other actions.

@Chisomchima Chisomchima requested a review from a team as a code owner June 3, 2024 16:18
@d-rita d-rita requested a review from kabaros June 3, 2024 16:33
Copy link
Contributor

@d-rita d-rita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise, this works as expected! I can tab to both parts of the splitButton and pressing Enter or Space activates them. Esc button closes the dropdown menu. 🎉

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 4, 2024

🚀 Deployed on https://pr-1512--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 4, 2024 08:52 Inactive
@kabaros kabaros enabled auto-merge (squash) June 4, 2024 15:53
@dhis2-bot dhis2-bot temporarily deployed to netlify July 3, 2024 10:51 Inactive
@kabaros
Copy link
Collaborator

kabaros commented Jul 3, 2024

after discussing with @Chisomchima , closing this one as it was superseded by #1458

@kabaros kabaros closed this Jul 3, 2024
auto-merge was automatically disabled July 3, 2024 14:16

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants