Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: give focus to menu opened by a dropdown #1503

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Chisomchima
Copy link
Contributor

Implements JIRA_ISSUE_ID


Description

Implement menu focusing when dropdown child contains a menu component.


Screenshot 2024-05-21 at 07 43 27

Screenshots

supporting text
Screenshot 2024-05-21 at 07 44 01

@Chisomchima Chisomchima requested a review from a team as a code owner May 21, 2024 06:46
@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 21, 2024

🚀 Deployed on https://pr-1503--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 06:55 Inactive
@Chisomchima Chisomchima force-pushed the LIBS-612/dropdown-menu-focus branch from fd44be8 to 3d4f156 Compare May 21, 2024 07:00
@dhis2-bot dhis2-bot temporarily deployed to netlify May 21, 2024 07:08 Inactive
Copy link

cypress bot commented May 21, 2024

Passing run #3385 ↗︎

0 584 0 0 Flakiness 0

Details:

chore: give focus to menu opened by a dropdown
Project: ui Commit: 3d4f156583
Status: Passed Duration: 09:00 💡
Started: May 21, 2024 7:17 AM Ended: May 21, 2024 7:26 AM

Review all test suite changes for PR #1503 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify June 5, 2024 15:11 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify June 19, 2024 07:52 Inactive
@flaminic
Copy link
Contributor

Hey @Chisomchima , Thanks, this looks good :)
I think it might be missing some extra scope, for when the menu is focused. Let's chat about this in person and I can explain what extra requirements might need implementation.

@flaminic
Copy link
Contributor

Hey @Chisomchima , Thanks, this looks good :) I think it might be missing some extra scope, for when the menu is focused. Let's chat about this in person and I can explain what extra requirements might need implementation.

Hey @Chisomchima , as we discussed earlier I spoke to Diana, and indeed she implemented all the above mentioned extra scope as part of this PR :)
So let's wait for that to be in before merging this PR.

@flaminic
Copy link
Contributor

flaminic commented Jul 3, 2024

@Chisomchima Now that the other PR was merged, as you said, this works great. Do you mind Addressing the typescript comment above and merging master so we can merge this?

@dhis2-bot dhis2-bot temporarily deployed to netlify July 3, 2024 13:10 Inactive
@Chisomchima Chisomchima requested a review from flaminic July 3, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants