fix: missing labels in report period selector #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-388--dhis2-reports.netlify.app |
tomzemp
approved these changes
May 6, 2024
There was a problem hiding this comment.
Looks good @alaa-yahia !
I think it might be helpful to also reduce this problem in the future by falling back to the backend name if we do not have translations. This would mean changing the line here:
to
displayName: fixedPeriodTranslations[periodType.name] ?? periodType.name,
|
Looks great from a functional testing side too! |
tomzemp
deleted the
DHIS2-16199-report-period-selector-in-reports-app-missing-labe
branch
|
🎉 This PR is included in version 100.0.57 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-16199