refactor: completely replace d2 by data engine

[HendrikThePendric]

• This is a redux app so I opted for using the data engine imperatively in the api module that already existed
• The majority of the changes are in that module, but GitHub will collapse this file, so be aware of that
• Some component changes were introduced as a result of the removal of the d2 adapter
• Other component changes were triggered by the fact that some things, like the current-user system version were previously read from the d2 instance

[varl]

Fix in app-shell for build failure: dhis2/app-platform#475

[ismay]

I've left a couple comments. In general I was also wondering:

• Why was index.js added in several imports? I'm used to omitting that since it's the default when importing a folder.
• With a large change like this it seems good to me to increase test coverage, especially in the affected areas. What do you think?

[HendrikThePendric]

• Why was index.js added in several imports? I'm used to omitting that since it's the default when importing a folder.

See this Slack comment and also the conversation above and below it. We prefer explicit over implicit.

• With a large change like this it seems good to me to increase test coverage, especially in the affected areas. What do you think?

Yeah in general I agree. I definitely think I will be adding tests when I try to remove redux from the app and move to the DataQuery/DataMutation. Probably I should have added tests prior to refactoring this. The main benefit of these tests IMO would be to catch regressions introduced by the refactor. I did not do so, and I wonder if adding these tests now would add much benefit since I've manually tested for regressions already. Given the fact that (the vast majority of) the changes are in the api-module, I think just checking if the date-engine-based version of a function produces the same request as the d2 based is probably sufficient. So what I am suggesting is to not add tests now, but add tests when we do the bigger refactor and switch from REDUX to the DataQuery/DataMutation approach.

[dhis2-bot]

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀