Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve support for right-to-left languages in Dashboard app #2985

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented May 31, 2024

Implements DHIS2-16778

Key features

  1. Use logical CSS properties instead of physical properties throughout the project (done automatically with a tool)
  2. Update the cli-style to a version that supports checking logical properties (and automatically converting physical to logical properties)

Description

This PR implements better support for right-to-left languages in the app, by leveraging the use of logical CSS properties that are independent of language direction, rather than physical properties (i.e. *-start instead of -left and *-end instead *-right). Logical properties are widely supported now and they should become the default way for layout going-forward to ensure that we support RTL languages without extra development burden (which will be enforced by d2 style).

Although the change set is big. It's mostly done automatically using d2 style apply css which under the hood uses stylelint to enforce and apply the rules.

The better support for RTL builds on top of previous work done in the platform, namely:

Testing

  • The main test here should be that the app in English (or any LTR language) should look exactly as before, after these changes.
  • Test on an environment set to Arabic (or any other RTL language) to confirm it looks as expected for an RTL user.

Screenshots

Before After
dashboard_before dashboard_after

Bumps [express](https://github.com/expressjs/express) from 4.18.1 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.1...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@kabaros kabaros marked this pull request as ready for review June 3, 2024 12:34
@kabaros kabaros requested a review from a team June 3, 2024 14:07
@jenniferarnesen jenniferarnesen changed the base branch from dev to master June 21, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants