feat: build with app platform, publish independent services #512
Conversation
| "@dhis2/app-runtime": "file:../../runtime", | ||
| "@dhis2/app-service-config": "file:../../services/config", | ||
| "@dhis2/app-service-data": "file:../../services/data", |
There was a problem hiding this comment.
Is it correct that the peerDeps should be linked to "file:" when "resolutions" is used below?
There was a problem hiding this comment.
I think it's the same either way? The dep (not peerDep) could be a version range, but the resolution takes precedence anyway. I think I needed this for the moment since the sup-packages aren't published on npm yet, so it broke when trying to resolve a version range.
There was a problem hiding this comment.
@varl technically, since there are no "deep" dependencies on @dhis2/app-service-{config|data} the resolutions were superfluous, so I've removed them but the file dep is still required
There was a problem hiding this comment.
While technically it works with only dependencies I think the resolutions are more important here (since they're not technically direct dependencies), we can remove the dependency entries once the service packages have been published.
|
Thanks @Mohammer5 ! |
# [2.2.0](v2.1.2...v2.2.0) (2020-05-06) ### Features * build with app platform, publish independent services ([#512](#512)) ([70aa726](70aa726))
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Requires dhis2/app-platform#368Closes #370
This migrates all app-service packages to build with DHIS2 App Platform (instead of running pretty much the same steps locally). This also makes all service packages (
@dhis2/app-service-configand@dhis2/app-service-data) public and published tonpm, so we don't have to worry about bundling them all together and so that types can be properly exposed and consumed by IDEs.For now type extraction and tsconfig settings remain in this repo, but eventually they should be baked into the platform so that typescript libs always output consistent type declaration files.