feat(init): set direction: 'auto' and import locales for new apps [LIBS-645] #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaminic
approved these changes
Aug 8, 2024
dhis2-bot
added a commit
that referenced
this pull request
Aug 12, 2024
# [12.0.0-alpha.6](v12.0.0-alpha.5...v12.0.0-alpha.6) (2024-08-12) ### Features * **init:** set direction: 'auto' and import locales for new apps [LIBS-645] ([#867](#867)) ([4eda4a9](4eda4a9))
|
🎉 This PR is included in version 12.0.0-alpha.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBS-645
Can be tested by checking out the branch and running
yarn d2-app-scripts init new-app(note that the new app will use the version ofcli-app-scriptson master):direction: 'auto'should be ind2.config.js, and setting an RTL language should display RTL direction (in the HTML, and the app text should look like "!Welcome to DHIS2")The separation between boilerplate and config defaults can also be tested by commenting out
direction: 'auto'in the config -- the currentdirection: 'ltr'default behavior should be restoredI think the version after the Vite migration would be a good time to update the default direction to 'auto' to try to avoid too many breaking changes with the migration
I also added the locale import to the entrypoint file, since that's a common oversight