Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: review feedback #773

Merged
merged 4 commits into from
Nov 25, 2022
Merged

refactor: review feedback #773

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb00982
chore: remove obsolete comment
KaiVandivier Nov 24, 2022
ef8723e
chore: add link to more explanation
KaiVandivier Nov 24, 2022
7f48b1b
chore: flag dhis2-specific changes in webpack config
KaiVandivier Nov 24, 2022
119f76b
chore: move plugin webpack config
KaiVandivier Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: flag dhis2-specific changes in webpack config
  • Loading branch information
@KaiVandivier
KaiVandivier committed Nov 24, 2022
commit 7f48b1b6975e30b20074b7fdf03a677da012b86a
3 changes: 1 addition & 2 deletions cli/src/lib/plugin/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ module.exports = ({ env: webpackEnv, config, paths }) => {
},
}),
},
// 'asset/resource' fixes fonts, but 'file-loader' breaks css modules
// dhis2: 'asset/resource' fixes fonts, but 'file-loader' breaks css modules
// when used for all asset types. So use each for respective files
{
test: /\.(woff|woff2|eot|ttf|otf)$/i,
Expand Down Expand Up @@ -310,6 +310,5 @@ module.exports = ({ env: webpackEnv, config, paths }) => {
},
// Saves some chunk size logging
performance: false,
// stats: 'verbose',
}
}