Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check authorities in app adapter [LIBS-370] #757

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

fix: check authorities in app adapter [LIBS-370] #757

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ce2938b
fix(sw): return !ok navigation responses instead of hitting precache
KaiVandivier Oct 14, 2022
b5dcd5f
fix(sw): don't use SWR on .json and .action requests
KaiVandivier Oct 14, 2022
858546c
feat(adapter): check user app authorities before rendering app
KaiVandivier Oct 14, 2022
b03b858
fix(adapter): use proper app authority name
KaiVandivier Oct 17, 2022
b882ed0
feat(adapter): add ui for auth boundary
KaiVandivier Oct 17, 2022
ea3ae21
fix(adapter): production env check
KaiVandivier Oct 17, 2022
7f97ca5
refactor: clean up verifyLatestUser
KaiVandivier Oct 17, 2022
1fe6278
chore: fix comment
KaiVandivier Oct 17, 2022
768e48d
refactor: extract useVerifyLatestUser and wrap just app with authBoun…
KaiVandivier Oct 17, 2022
431fa72
fix: notice box text
KaiVandivier Oct 18, 2022
7fb97ef
chore: i18n
KaiVandivier Oct 18, 2022
6ddc7e1
chore: add name and title to pwa example app
KaiVandivier Oct 20, 2022
09b100c
fix: ensure core app name formatting and handle legacy versions
KaiVandivier Oct 20, 2022
0668608
test: fix tests
KaiVandivier Oct 21, 2022
d5ed304
Merge branch 'master' into fix/pwa-handle-navigations
KaiVandivier Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(sw): don't use SWR on .json and .action requests
  • Loading branch information
@KaiVandivier
KaiVandivier committed Oct 14, 2022
commit b5dcd5fea08375f2f549200fcb732fd47042062d
3 changes: 2 additions & 1 deletion pwa/src/service-worker/service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ export function setUpServiceWorker() {
({ url }) =>
PRODUCTION_ENV &&
urlMeetsAppShellCachingCriteria(url) &&
fileExtensionRegexp.test(url.pathname),
fileExtensionRegexp.test(url.pathname) &&
!/\.(json|action)/.test(url.pathname), // don't SWR these
KaiVandivier marked this conversation as resolved.
Show resolved Hide resolved
new StaleWhileRevalidate({ cacheName: 'other-assets' })
)

Expand Down