chore: clarify todos

adapter/src/components/ServerVersionProvider.js

@@ -55,7 +55,7 @@ export const ServerVersionProvider = ({
  return
  }
  // If no URL found in DB, try localStorage
- // TODO: deprecate
+ // (previous adapter versions stored the base URL there)
  const baseUrlFromLocalStorage =
  window.localStorage.DHIS2_BASE_URL
  if (baseUrlFromLocalStorage) {

examples/pwa-app/src/components/RequestTester.js

@@ -1,5 +1,6 @@
 import { useDataEngine } from '@dhis2/app-runtime'
-// todo: update import once app-runtime is released
+// importing from app-service-offline makes testing locally simpler
+// todo: update import to app-runtime once app-runtime PR is merged
 // import { useDhis2ConnectionStatus } from '@dhis2/app-service-offline'
 import { Box, Button, ButtonStrip, Help } from '@dhis2/ui'
 import React from 'react'
@@ -16,8 +17,8 @@ const query = {
 export default function RequestTester() {
  const engine = useDataEngine()
 
- // todo: uncomment this and the import to test once the 'temp' scripts in
- // pkg.json have been run
+ // While testing this PR, uncomment this and the import to test once the
+ // 'temp' scripts in pkg.json have been run:
  // const { isConnected, lastConnected } = useDhis2ConnectionStatus()
  const [isConnected, lastConnected] = [true, null]
 

pwa/src/lib/base-url-db.js

@@ -32,13 +32,11 @@ function openBaseUrlsDB() {
  })
 }
 
-/** Deletes the DB */
+/** Deletes the DB (probably not needed) */
 // function deleteBaseUrlsDB() {
 // return deleteDB(BASE_URL_DB)
 // }
 
-// todo: maybe this should also send a message to the service worker
-// that can be handled by the next requests... but what if no requests happen?
 export async function setBaseUrlByAppName({ appName, baseUrl }) {
  const db = await openBaseUrlsDB()
  return db.put(BASE_URL_STORE, { appName, baseUrl })

pwa/src/service-worker/dhis2-connection-status.js

@@ -27,7 +27,7 @@ export function initDhis2ConnectionStatus() {
 // Throttle this a bit to reduce SW/client messaging
 const BROADCAST_INTERVAL_MS = 1000
 const broadcastDhis2ConnectionStatus = throttle(async (isConnected) => {
- // todo: remove
+ // todo: remove log after testing the PR
  console.log('sw: broadcasting update', { newIsConnected: isConnected })
 
  const clients = await getAllClientsInScope()
@@ -62,7 +62,7 @@ async function isRequestToDhis2Server(request) {
  * https://developer.chrome.com/docs/workbox/using-plugins/
  */
 export const dhis2ConnectionStatusPlugin = {
- // todo: remove console logs
+ // todo: remove console logs after testing the PR
  fetchDidFail: async ({ request, error }) => {
  console.log('sw: fetch FAILED', { request, error })