Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide the app's name & version to the <HeaderBar> #674

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: provide the app's name & version to the <HeaderBar> #674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f5617e
feat(shell): add app version to env vars
Mohammer5 Sep 30, 2021
d36640e
feat(adapter): forward "appVersion" to <HeaderBar>
Mohammer5 Oct 7, 2021
9ed361a
chore: fix linter issues
Mohammer5 Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: fix linter issues
  • Loading branch information
@Mohammer5
Mohammer5 committed Oct 7, 2021
commit 9ed361a7babc382622469917c6a6babf6671ebff
9 changes: 8 additions & 1 deletion adapter/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,14 @@ import { ServerVersionProvider } from './components/ServerVersionProvider'

const offlineInterface = new OfflineInterface()

const AppAdapter = ({ url, apiVersion, appName, appVersion, pwaEnabled, children }) => (
const AppAdapter = ({
url,
apiVersion,
appName,
appVersion,
pwaEnabled,
children,
}) => (
<ErrorBoundary fullscreen onRetry={checkForSWUpdateAndReload}>
<ServerVersionProvider
url={url}
Expand Down
6 changes: 5 additions & 1 deletion cli/src/lib/shell/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ module.exports = ({ config, paths }) => ({
cmd: 'yarn',
args: ['run', 'start'],
cwd: paths.shell,
env: getEnv({ ...getAppInfos(config), port, ...getPWAEnvVars(config) }),
env: getEnv({
...getAppInfos(config),
port,
...getPWAEnvVars(config),
}),
pipe: false,
})
},
Expand Down