Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update react-scripts and cli-style at same time to use eslint 7 #475

Merged
merged 7 commits into from
Oct 30, 2020
Merged

fix: update react-scripts and cli-style at same time to use eslint 7 #475

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3edcce2
fix: do not automatically extend eslint configuration
varl Oct 30, 2020
647b059
chore: update react-scripts and cli-style
varl Oct 30, 2020
b14673d
ci: build first to ensure imports are available
varl Oct 30, 2020
eb5c9e7
chore: use yarn workspace commands
varl Oct 30, 2020
058eabf
ci: use unified workflows for caching
varl Oct 30, 2020
e44e5a2
ci: download build artifacts
varl Oct 30, 2020
aecb1f6
ci: build before lint to generate locales
varl Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: build first to ensure imports are available
  • Loading branch information
@varl
varl committed Oct 30, 2020
commit b14673d97f0b0ec4fcb3b1dd6b7bbb7973c9eede
18 changes: 10 additions & 8 deletions .github/workflows/dhis2-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ env:
CI: true

jobs:
lint:
build:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
Expand All @@ -29,13 +29,12 @@ jobs:
- name: Install
run: yarn install --frozen-lockfile

- name: Run linters
run: |
yarn d2-style js check
yarn d2-style text check
- name: Build
run: yarn build

build:
lint:
runs-on: ubuntu-latest
needs: build
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
- uses: actions/checkout@v2
Expand All @@ -57,11 +56,14 @@ jobs:
- name: Install
run: yarn install --frozen-lockfile

- name: Build
run: yarn build
- name: Run linters
run: |
yarn d2-style js check
yarn d2-style text check

test:
runs-on: ubuntu-latest
needs: build
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
- uses: actions/checkout@v2
Expand Down