-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve start behavior and logging, don't orphan react-scripts, add postcss #34
Conversation
Deploy preview for dhis2-app-platform ready! Built with commit 5049038 |
The addition of I don't have the opportunity to try this tonight but will give it a whirl in the morning. Looks pretty slick! |
I was thinking about dropping postcss and adding it later, but figured since the compilation failed when it hit a CSS import before it could be considered a fix (doesn't change the API). Either way fine with me, we might want to do CSS imports differently in the future anyways. The library in question that @erikarenhill was trying to use was @dhis2/analytics - this gets past the CSS import issue but there are other issues we'll need to deal with as well. Taking out PostCSS for now |
Yeah, avoiding the css-loader situation was one of the reasons we rewrote ui-core from postcss to styled-jsx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine. 👍
Yep, agreed. Libraries with I'll open another PR next week to address this and other issues importing some of our legacy libraries |
## [1.2.3](v1.2.2...v1.2.3) (2019-09-06) ### Bug Fixes * improve start behavior and logging, don't orphan react-scripts, add postcss ([#34](#34)) ([f9edd31](f9edd31))
This has one important functional change - we wait for the app build to succeed before starting the appShell server, so we don't run the risk of orphaning the server process if/when the first compilation fails (a fatal error in rollup). This also: