fix(proxy): ignore nulls in transformJsonResponse #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
approved these changes
Jun 8, 2022
Mohammer5
approved these changes
Jun 8, 2022
|
Good catch, nice investigation @Birkbjo ! |
Birkbjo
force-pushed
the
fix/proxy-dont-transform-nulls
branch
from
314ca66
to
f52d5d8
Compare
dhis2-bot
added a commit
that referenced
this pull request
Jun 8, 2022
## [9.0.1](v9.0.0...v9.0.1) (2022-06-08) ### Bug Fixes * **proxy:** ignore nulls in transformJsonResponse ([#719](#719)) ([b72dd79](b72dd79))
|
🎉 This PR is included in version 9.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug caused objects that had
property: nullto be converted to{}. This was causing thedata-entry-appto crash, and was a pretty obscure bug to track down. The root of the issue is thattypeof null === 'object', and when using_transformwith a default of{}, allnull-properties were transformed to{}.