fix(proxy): ignore nulls in transformJsonResponse (#719)

* fix(proxy): ignore nulls in transformJsonResponse * style: fix linting errors * chore: try run lint
dhis2 · Jun 8, 2022 · b72dd79 · b72dd79
1 parent ede728c
commit b72dd79
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/cli/src/lib/proxy.js b/cli/src/lib/proxy.js
@@ -54,6 +54,9 @@ const transformJsonResponse = (res, { target, baseUrl }) => {
  transformJsonResponse(r, { target, baseUrl })
  )
  }
+ if (res === null) {
+ return res
+ }
  return _.transform(
  res,
  (result, value, key) => {

diff --git a/cli/src/lib/proxy.test.js b/cli/src/lib/proxy.test.js
@@ -20,6 +20,28 @@ describe('transformJsonResponse', () => {
  'http:https://localhost:8080/api/endpoint'
  )
  })
+
+ it('should not convert nulls to {}', () => {
+ const transformedResponse = transformJsonResponse(
+ {
+ a: {
+ b: {
+ c: 'https://play.dhis2.org/dev/api/endpoint',
+ },
+ d: null,
+ },
+ },
+ {
+ target: 'https://play.dhis2.org/dev',
+ baseUrl: 'http:https://localhost:8080',
+ }
+ )
+
+ expect(transformedResponse.a.b.c).toBe(
+ 'http:https://localhost:8080/api/endpoint'
+ )
+ expect(transformedResponse.a.d).toBe(null)
+ })
 })
 
 describe('rewriteLocation', () => {