fix(fs): re-read package.json from disk to make sure it is not stale

dhis2 · Jun 30, 2021 · 918d113 · 918d113
1 parent 00a7dc1
commit 918d113
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/cli/src/commands/init.js b/cli/src/commands/init.js
@@ -101,7 +101,7 @@ const handler = async ({ force, name, cwd, lib }) => {
  }
 
  reporter.info('Creating package scripts...')
- const pkg = require(paths.package)
+ const pkg = fs.readJsonSync(paths.package)
  if (pkg.scripts && pkg.scripts.build && !force) {
  reporter.warn(
  'A script called "build" already exists, use --force to overwrite it'

diff --git a/cli/src/lib/parseConfig.js b/cli/src/lib/parseConfig.js
@@ -67,7 +67,7 @@ const parseConfig = paths => {
  config = defaultsDeep(config, require(defaults))
 
  if (fs.existsSync(paths.package)) {
- const pkg = require(paths.package)
+ const pkg = fs.readJsonSync(paths.package)
  config.name = config.name || pkg.name
  config.version = config.version || pkg.version
  config.author = config.author || parseAuthor(pkg.author)

diff --git a/cli/src/lib/validatePackage.js b/cli/src/lib/validatePackage.js
@@ -1,4 +1,5 @@
 const { reporter, chalk } = require('@dhis2/cli-helpers-engine')
+const fs = require('fs-extra')
 const {
  validatePackageExports,
 } = require('./validators/validatePackageExports')
@@ -16,7 +17,7 @@ module.exports.validatePackage = async ({
 
  let pkg
  try {
- pkg = require(paths.package)
+ pkg = fs.readJsonSync(paths.package)
  } catch (e) {
  reporter.error(`Failed to load package manifest at ${paths.package}`)
  return false