fix: apply legend to all numeric and boolean types (DHIS2-17611) #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhenrikoverland
changed the title
edoardo
requested changes
Jun 20, 2024
…/analytics into fix/pivot-tables-legend-value-type
edoardo
approved these changes
Jun 20, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jun 26, 2024
## [26.7.6](v26.7.5...v26.7.6) (2024-06-26) ### Bug Fixes * apply legend to all numeric and boolean types (DHIS2-17611) ([#1683](#1683)) ([e93b106](e93b106))
|
🎉 This PR is included in version 26.7.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17611
Description
This PR does two things:
NUMBER, to support event data items.0is stripped so that the number of "Yes" is presented as3instead of3.0TODO
Screenshots
Before
After
(The negative integer value is just out of bounds of the legend set)