feat(pivot-table): truncate title and show full in tooltip (DHIS2-14827) #1579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14827
Key features
Description
Before adding the tooltip functionality, I also addressed a small bug: the
max-width
fordiv.title-cell-content
didn't take into account the cell padding and border and as such the value was a bit too high.The tooltip is only added if the title text is overflowing the container.
I also added a story to demo the feature.
Considerations
div.title-cell-content
, which is the tooltip anchor element, has 5px of whitespace around it. So the tooltip only shows when hovering the actual text, not the entire table cell. I'm not sure if this is a bug or a feature. I think changing this behaviour should be relatively simple, but just not sure whether we want to.TODO
Screenshots