Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added the following in rosboard/rosboard.py after line 135 and it works. #119

Closed
altineller opened this issue Sep 27, 2023 · 3 comments
Closed

Comments

@altineller
Copy link

It fixed this error but now:

[INFO] [1695856654.803669864] [rosboard_node]: Subscribing to /scan
[WARN] [1695856654.804567837] [rosboard_node]: name 'HistoryPolicy' is not defined
Traceback (most recent call last):
File "/home/can/workspaces/rosboard_ws/install/rosboard/lib/python3.10/site-packages/rosboard/rosboard.py", line 264, in sync_subs
kwargs = {"qos": self.get_topic_qos(topic_name)}
File "/home/can/workspaces/rosboard_ws/install/rosboard/lib/python3.10/site-packages/rosboard/rosboard.py", line 137, in get_topic_qos
if(topic_info[0].qos_profile.history == HistoryPolicy.UNKNOWN):
NameError: name 'HistoryPolicy' is not defined
[INFO] [1695856655.809106101] [rosboard_node]: Subscribing to /scan
[WARN] [1695856655.812603795] [rosboard_node]: name 'HistoryPolicy' is not defined

          I added the following in `rosboard/rosboard.py` after line 135 and it works.
                if(topic_info[0].qos_profile.history == HistoryPolicy.UNKNOWN):
                    topic_info[0].qos_profile.history = HistoryPolicy.KEEP_LAST  

Originally posted by @HX2003 in #104 (review)

@altineller
Copy link
Author

Adding:

import rclpy
import rclpy.logging
import rclpy.qos
import rclpy.qos_event

As well changing lines after 135 to:

            if(topic_info[0].qos_profile.history == rclpy.qos.HistoryPolicy.UNKNOWN):
                topic_info[0].qos_profile.history = rclpy.qos.HistoryPolicy.KEEP_LAST

is required to make it work

renemoll added a commit to renemoll/rosboard that referenced this issue Nov 29, 2023
@Hoolo
Copy link

Hoolo commented Dec 8, 2023

This worked for me both on ROS2 Foxy & Humble, thanks!

@dheera
Copy link
Owner

dheera commented Jun 20, 2024

Thanks! I merged another PR recently that fixed this as well. Let me know if it is an issue in any of your configurations now. Thanks!

@dheera dheera closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants