Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PNaCL #19

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Drop support for PNaCL #19

merged 1 commit into from
Oct 28, 2017

Conversation

pitdicker
Copy link

Now that rustc and Google now longer support it, it seems we can remove the code from OsRng.
See rust-lang/rust#45041 and rust-lang/rust#42420

@dhardy
Copy link
Owner

dhardy commented Oct 23, 2017

Be nice to remove that, but issue linked (#42420) mentions that only PNaCl is deprecated, not Google NaCl.

@pitdicker
Copy link
Author

Hmmm, yes. It is a bit messy

From rust-lang/rust#42420 (comment):

I think NaCl has gotten some use outside the browser, so I could imagine a case for still supporting NaCl in Rust. It's probably only worth doing if there are current users of it though.

I read that as: the primary use case for target_os = "nacl" is to support running Rust code in browsers. That is not available anymore. Maybe there is someone be uses Rust together with the NaCl sandboxing technology. Probably not, but we don't know.

Personally, I would rather remove it. If there is really somebody using it, say sorry and add it back.
Instead of modifying it now to add proper error handling, and going through the trouble to somehow test it.

@dhardy dhardy merged commit 819a282 into dhardy:master Oct 28, 2017
@pitdicker pitdicker deleted the drop_pnacl branch October 31, 2017 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants