[pull] master from JuliaLang:master #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The fallback definitions of `reduce_empty` and `mapreduce_empty` are big targets for invalidation, and the benefit they bring is questionable. Instead of having a dedicated error path, instead we print a custom `MethodError` hint that is more informative than the current message. This fixes ~500 invalidations from DiffEqBase
`arg_types_param` is known to be a `Core.SimpleVector`
Co-authored-by: Martin Holters <[email protected]>
- two functions affected by `Core.Box` (#15276) were ameliorated - type info added to the `stack` field of `ExceptionStack` - avoid unknown dispatch from de-specialized code Co-authored-by: Jameson Nash <[email protected]>
* Remove unspecialized `reduce_empty` The fallback definitions of `reduce_empty` and `mapreduce_empty` are big targets for invalidation, and the benefit they bring is questionable. Instead of having a dedicated error path, instead we print a custom `MethodError` hint that is more informative than the current message. This fixes ~500 invalidations from DiffEqBase * Allow specialization in show_convert_error `arg_types_param` is known to be a `Core.SimpleVector`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 馃挅 Please sponsor : )