Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to stop more than 1 tone's playback #13

Open
dgets opened this issue Feb 9, 2019 · 1 comment
Open

Figure out how to stop more than 1 tone's playback #13

dgets opened this issue Feb 9, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dgets
Copy link
Owner

dgets commented Feb 9, 2019

With commit 7485b5f, playback and stopping playback for a single tone is working without any issues. However, due to the asynchronous nature of things, it is possible to play back more than one tone at a time. When this happens, clicking the associated preset list item to try to stop the tone will only end a single tone. Multiple clicks to the other entries will start playback for more, but you cannot end the playback of other concurrent tones; at least not all of them. This needs to be fixed; unless, due to the way things are set up, it turns into a nightmare, in which case it might be easier to just limit playbacks to one tone at a time until I've gotten through enough Android and Java classes/tutorials to be able to handle this the right way.

@dgets dgets added the bug Something isn't working label Feb 9, 2019
@dgets dgets added this to the alpha milestone Feb 9, 2019
@dgets dgets self-assigned this Feb 9, 2019
dgets added a commit that referenced this issue Feb 9, 2019
@dgets
Copy link
Owner Author

dgets commented Feb 9, 2019

I went for limiting playback to one sole tone, for now. Just an interim solution until I learn the proper way to deal with this while allowing multiple tones to be played simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant