Roominfo rewrite #137
Merged
Roominfo rewrite #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgets
added a commit
that referenced
this pull request
May 20, 2015
Roominfo rewrite has added successful additions in being able to correctly write and read the room info blobs. Control structure around these bits still has to be added, but the featureset is improved at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Room info, while not perfectly implemented (ie it's not yet determining if a person is the one that should be able to modify room info, nor timestamping yet due to my hesitance on settling on a timestamp format) is now correctly saving and reading the room info. That's good enough to push to dev for me for right now. Rewriting really helped it out a lot.