Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize reconciliation from addition to deletion in containers #695

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Prioritize reconciliation from addition to deletion in containers #695

merged 7 commits into from
Sep 12, 2023

Conversation

jalal246
Copy link
Member

@jalal246 jalal246 commented Sep 6, 2023

No description provided.

@github-actions github-actions bot added the DnD label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/dflex-dnd/dist/dflex-dnd.mjs 10.57 KB (0%) 212 ms (0%) 134 ms (-79.54% 🔽) 346 ms
packages/dflex-core-instance/dist/dflex-core.mjs 147 B (0%) 10 ms (0%) 76 ms (-81.53% 🔽) 86 ms
packages/dflex-dom-gen/dist/dflex-dom.mjs 23 B (0%) 10 ms (0%) 56 ms (-84.42% 🔽) 66 ms
packages/dflex-store/dist/dflex-store.mjs 322 B (0%) 10 ms (0%) 73 ms (-84.22% 🔽) 83 ms
packages/dflex-utils/dist/dflex-utils.mjs 249 B (+1.22% 🔺) 10 ms (0%) 58 ms (-72.9% 🔽) 68 ms
packages/dflex-draggable/dist/dflex-draggable.mjs 5.71 KB (+1.01% 🔺) 115 ms (+1.01% 🔺) 51 ms (-80.67% 🔽) 165 ms

@jalal246 jalal246 changed the title init Implement deleted element tracking for race condition management in observer/unrgister Sep 9, 2023
@jalal246 jalal246 force-pushed the dev/wip_9_8 branch 2 times, most recently from d8b0f44 to 89db723 Compare September 10, 2023 11:09
@jalal246
Fix Failing Test by Adding Missing Test Case (#700)
dc4c47a 
* remove console fixing the test results

* fix test
@jalal246 jalal246 changed the title Implement deleted element tracking for race condition management in observer/unrgister Prioritize reconciliation from addition to deletion in containers Sep 12, 2023
@jalal246 jalal246 merged commit d9483e3 into main Sep 12, 2023
15 of 17 checks passed
@jalal246 jalal246 deleted the dev/wip_9_8 branch September 12, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Core DnD Dom-Gen Store Test 🧪 Utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jalal246