Skip to content

Tags: dfinity/nns-dapp

Tags

tip

Toggle tip's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
NNS1-3435: Reuse ConfirmationModal styles through other consumers of …

…ConfirmationModal (#5740)

# Motivation

There is a common `ConfirmationModal` component that should be reused
for many different flows.

# Changes

* Removes custom css by consumers of `ConfirmationModal` and reuses
exported css from the confirmation-modal styles.

# Tests

Testable under
https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/

**VoteConfirmationModal**

Before:
<img width="533" alt="Screenshot 2024-11-07 at 11 57 28"
src="https://github.com/user-attachments/assets/c786033a-a048-4e99-a154-047179dc7c7e">

After:
<img width="543" alt="Screenshot 2024-11-07 at 13 04 25"
src="https://github.com/user-attachments/assets/ed126f03-8e43-49b3-81b2-ebf5b6ed9012">


**DissolveActionButtonModal**

Before:
<img width="688" alt="Screenshot 2024-11-07 at 13 20 48"
src="https://github.com/user-attachments/assets/a1704caa-9046-4501-8010-2bcf653378e1">

Title alignment will be fixed generally after this MR.

After:
<img width="598" alt="Screenshot 2024-11-07 at 13 21 03"
src="https://github.com/user-attachments/assets/b3b9c92c-5bdb-4bd6-84c9-0347b6f973a0">

**ImportTokenRemoveConfirmation**:

Before:
<img width="557" alt="Screenshot 2024-11-07 at 13 45 05"
src="https://github.com/user-attachments/assets/04f118a6-ade3-4a07-b4c0-0776c4dd413e">

After:
<img width="594" alt="Screenshot 2024-11-07 at 13 49 38"
src="https://github.com/user-attachments/assets/244212df-1b45-480e-9895-6145c8235130">


**HardwareWalletNeuronAddHotkeyModal**

Before:
<img width="948" alt="Screenshot 2024-11-07 at 13 55 47"
src="https://github.com/user-attachments/assets/ca994f07-2bd1-49de-b069-448345850592">

After:
<img width="683" alt="Screenshot 2024-11-08 at 09 47 06"
src="https://github.com/user-attachments/assets/5dec62c5-6d1e-4501-a66c-f4c3474cfef5">

# Todos

- [ ] Add entry to changelog (if necessary)
Not necessary.

nightly-2024-11-11

Toggle nightly-2024-11-11's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
NNS1-3435: Reuse ConfirmationModal styles through other consumers of …

…ConfirmationModal (#5740)

# Motivation

There is a common `ConfirmationModal` component that should be reused
for many different flows.

# Changes

* Removes custom css by consumers of `ConfirmationModal` and reuses
exported css from the confirmation-modal styles.

# Tests

Testable under
https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/

**VoteConfirmationModal**

Before:
<img width="533" alt="Screenshot 2024-11-07 at 11 57 28"
src="https://github.com/user-attachments/assets/c786033a-a048-4e99-a154-047179dc7c7e">

After:
<img width="543" alt="Screenshot 2024-11-07 at 13 04 25"
src="https://github.com/user-attachments/assets/ed126f03-8e43-49b3-81b2-ebf5b6ed9012">


**DissolveActionButtonModal**

Before:
<img width="688" alt="Screenshot 2024-11-07 at 13 20 48"
src="https://github.com/user-attachments/assets/a1704caa-9046-4501-8010-2bcf653378e1">

Title alignment will be fixed generally after this MR.

After:
<img width="598" alt="Screenshot 2024-11-07 at 13 21 03"
src="https://github.com/user-attachments/assets/b3b9c92c-5bdb-4bd6-84c9-0347b6f973a0">

**ImportTokenRemoveConfirmation**:

Before:
<img width="557" alt="Screenshot 2024-11-07 at 13 45 05"
src="https://github.com/user-attachments/assets/04f118a6-ade3-4a07-b4c0-0776c4dd413e">

After:
<img width="594" alt="Screenshot 2024-11-07 at 13 49 38"
src="https://github.com/user-attachments/assets/244212df-1b45-480e-9895-6145c8235130">


**HardwareWalletNeuronAddHotkeyModal**

Before:
<img width="948" alt="Screenshot 2024-11-07 at 13 55 47"
src="https://github.com/user-attachments/assets/ca994f07-2bd1-49de-b069-448345850592">

After:
<img width="683" alt="Screenshot 2024-11-08 at 09 47 06"
src="https://github.com/user-attachments/assets/5dec62c5-6d1e-4501-a66c-f4c3474cfef5">

# Todos

- [ ] Add entry to changelog (if necessary)
Not necessary.

nightly-2024-11-10

Toggle nightly-2024-11-10's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
NNS1-3435: Reuse ConfirmationModal styles through other consumers of …

…ConfirmationModal (#5740)

# Motivation

There is a common `ConfirmationModal` component that should be reused
for many different flows.

# Changes

* Removes custom css by consumers of `ConfirmationModal` and reuses
exported css from the confirmation-modal styles.

# Tests

Testable under
https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/

**VoteConfirmationModal**

Before:
<img width="533" alt="Screenshot 2024-11-07 at 11 57 28"
src="https://github.com/user-attachments/assets/c786033a-a048-4e99-a154-047179dc7c7e">

After:
<img width="543" alt="Screenshot 2024-11-07 at 13 04 25"
src="https://github.com/user-attachments/assets/ed126f03-8e43-49b3-81b2-ebf5b6ed9012">


**DissolveActionButtonModal**

Before:
<img width="688" alt="Screenshot 2024-11-07 at 13 20 48"
src="https://github.com/user-attachments/assets/a1704caa-9046-4501-8010-2bcf653378e1">

Title alignment will be fixed generally after this MR.

After:
<img width="598" alt="Screenshot 2024-11-07 at 13 21 03"
src="https://github.com/user-attachments/assets/b3b9c92c-5bdb-4bd6-84c9-0347b6f973a0">

**ImportTokenRemoveConfirmation**:

Before:
<img width="557" alt="Screenshot 2024-11-07 at 13 45 05"
src="https://github.com/user-attachments/assets/04f118a6-ade3-4a07-b4c0-0776c4dd413e">

After:
<img width="594" alt="Screenshot 2024-11-07 at 13 49 38"
src="https://github.com/user-attachments/assets/244212df-1b45-480e-9895-6145c8235130">


**HardwareWalletNeuronAddHotkeyModal**

Before:
<img width="948" alt="Screenshot 2024-11-07 at 13 55 47"
src="https://github.com/user-attachments/assets/ca994f07-2bd1-49de-b069-448345850592">

After:
<img width="683" alt="Screenshot 2024-11-08 at 09 47 06"
src="https://github.com/user-attachments/assets/5dec62c5-6d1e-4501-a66c-f4c3474cfef5">

# Todos

- [ ] Add entry to changelog (if necessary)
Not necessary.

nightly-2024-11-09

Toggle nightly-2024-11-09's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
NNS1-3435: Reuse ConfirmationModal styles through other consumers of …

…ConfirmationModal (#5740)

# Motivation

There is a common `ConfirmationModal` component that should be reused
for many different flows.

# Changes

* Removes custom css by consumers of `ConfirmationModal` and reuses
exported css from the confirmation-modal styles.

# Tests

Testable under
https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/

**VoteConfirmationModal**

Before:
<img width="533" alt="Screenshot 2024-11-07 at 11 57 28"
src="https://github.com/user-attachments/assets/c786033a-a048-4e99-a154-047179dc7c7e">

After:
<img width="543" alt="Screenshot 2024-11-07 at 13 04 25"
src="https://github.com/user-attachments/assets/ed126f03-8e43-49b3-81b2-ebf5b6ed9012">


**DissolveActionButtonModal**

Before:
<img width="688" alt="Screenshot 2024-11-07 at 13 20 48"
src="https://github.com/user-attachments/assets/a1704caa-9046-4501-8010-2bcf653378e1">

Title alignment will be fixed generally after this MR.

After:
<img width="598" alt="Screenshot 2024-11-07 at 13 21 03"
src="https://github.com/user-attachments/assets/b3b9c92c-5bdb-4bd6-84c9-0347b6f973a0">

**ImportTokenRemoveConfirmation**:

Before:
<img width="557" alt="Screenshot 2024-11-07 at 13 45 05"
src="https://github.com/user-attachments/assets/04f118a6-ade3-4a07-b4c0-0776c4dd413e">

After:
<img width="594" alt="Screenshot 2024-11-07 at 13 49 38"
src="https://github.com/user-attachments/assets/244212df-1b45-480e-9895-6145c8235130">


**HardwareWalletNeuronAddHotkeyModal**

Before:
<img width="948" alt="Screenshot 2024-11-07 at 13 55 47"
src="https://github.com/user-attachments/assets/ca994f07-2bd1-49de-b069-448345850592">

After:
<img width="683" alt="Screenshot 2024-11-08 at 09 47 06"
src="https://github.com/user-attachments/assets/5dec62c5-6d1e-4501-a66c-f4c3474cfef5">

# Todos

- [ ] Add entry to changelog (if necessary)
Not necessary.

nightly-2024-11-08

Toggle nightly-2024-11-08's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
FOLLOW-244: Stop claiming neurons in the nns-dapp canister (#5738)

# Motivation

Staking a neuron requires 2 steps: transferring the stake and claiming
the neuron.
Both steps are done in ic-js.
But it's possible that the process gets interrupted in between.
In this case the process needs to be finished later.
This is now done in the frontend so it no longer needs to be done in the
backend.

# Changes

1. Remove logic to detect stake neuron transaction and claim neurons
from the nns-dapp canister code.

# Tests

1. Unit test removed.

# Todos

- [x] Add entry to changelog (if necessary).
existing entry updated

release-candidate

Toggle release-candidate's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
FOLLOW-244: Do not try to claim the same neuron multiple times in a s…

…ession (#5733)

# Motivation

When the frontend sees a staking transaction without a corresponding
neuron, it tries to claim the neuron in case claiming it was
interrupted.
We don't need to do this more than once so we store the account
identifier to at least not do it more than once per session.

# Changes

1. If we find a staking transaction, add the neuron account identifier
to `checkedNeuronSubaccountsStore` and if it was already there, don't
try to claim the neuron.

# Tests

1. Unit test added. Tested that the test fails without the new code.

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary

proposal-134037

Toggle proposal-134037's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
FOLLOW-244: Do not try to claim the same neuron multiple times in a s…

…ession (#5733)

# Motivation

When the frontend sees a staking transaction without a corresponding
neuron, it tries to claim the neuron in case claiming it was
interrupted.
We don't need to do this more than once so we store the account
identifier to at least not do it more than once per session.

# Changes

1. If we find a staking transaction, add the neuron account identifier
to `checkedNeuronSubaccountsStore` and if it was already there, don't
try to claim the neuron.

# Tests

1. Unit test added. Tested that the test fails without the new code.

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary

nightly-2024-11-07

Toggle nightly-2024-11-07's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
FOLLOW-244: Remove MultiPartTransactionToBeProcessed::TopUpNeuron (#5735

)

# Motivation

#5706 removed the functionality
to top up neurons from the nns-dapp canister.
Because `TopUpNeuron` transactions could be on the queue when the
canister is upgraded, I didn't remove the
`MultiPartTransactionToBeProcessed::TopUpNeuron` enum value yet.
Now that the current version on mainnet no longer adds `TopUpNeuron` to
the queue, it should be safe to remove this value from the enum type.

# Changes

1. Remove `TopUpNeuron` from `MultiPartTransactionToBeProcessed`.

# Tests

CI passes.

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary

nightly-2024-11-06

Toggle nightly-2024-11-06's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Bump gix (#5727)

# Motivation

The dark theme has been updated.

# Changes

- Run `update:gix`.
- Upgraded screenshots because of the icon change.

# Tests

Demo:
https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/
<img width="1178" alt="image"
src="https://github.com/user-attachments/assets/17cf5704-4cb7-4086-bf69-4e687d3fe382">

# Todos

- [x] Add entry to changelog (if necessary).

nightly-2024-11-05

Toggle nightly-2024-11-05's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
bot: Update proposals candid bindings (#5720)

# Motivation
We would like to render all the latest proposal types.
Even with no changes, just updating the reference is good practice.

# Changes
* Update the version of `IC_COMMIT_FOR_PROPOSALS` specified in
`dfx.json`.
* Updated the `proposals` candid files to the versions in that commit.
* Updated the Rust code derived from `.did` files in the proposals
payload rendering crate.

# Tests
- [ ] Please check the API updates for any breaking changes that affect
our code.
  - [ ] Please check for new proposal types and add tests for them.

Breaking changes are:
  * New mandatory fields
    * Removing mandatory fields
    * Renaming fields
    * Changing the type of a field
    * Adding new variants

Co-authored-by: gix-bot <[email protected]>