Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update starter project #74

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Update starter project #74

merged 9 commits into from
Feb 20, 2024

Conversation

rvanasa
Copy link
Collaborator

@rvanasa rvanasa commented Feb 20, 2024 •
edited
Loading

This PR makes the following changes:

  • Bumps npm package versions.
  • Replaces "IC 🔗 ETH" with "ICP 🔗 Ethereum" due to several questions about whether "IC" refers to the $IC token.
  • Adjusts the login functionality in the local replica.
  • Replaces the deprecated ethereum.selectedAddress with an eth_accounts MetaMask RPC call.

@rvanasa rvanasa requested a review from a team as a code owner February 20, 2024 05:28
@rvanasa rvanasa mentioned this pull request Feb 20, 2024
Draft
@rvanasa rvanasa enabled auto-merge (squash) February 20, 2024 16:53
@rvanasa rvanasa merged commit 315166b into main Feb 20, 2024
3 checks passed
@rvanasa rvanasa deleted the update branch February 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rvanasa