Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SubnetChangeRequest to work with Generics #538

Merged
merged 19 commits into from
Jun 26, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

No description provided.

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner June 26, 2024 12:03
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as draft June 26, 2024 12:03
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Refactor change Refactor SubnetChangeRequest to work with Generics Jun 26, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as ready for review June 26, 2024 12:35
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks!

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 7e4947b into main Jun 26, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the refactor-extend-subnet-change-request branch June 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants