Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dre): Rename --simulate to --dry-run #504

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore(dre): Rename --simulate to --dry-run #504

merged 1 commit into from
Jun 20, 2024

Conversation

sasa-tomic
Copy link
Member

  • this makes it more consistent with ic-admin
  • it's backwards compatible since the old arguments are still accepted

@sasa-tomic
chore(dre): Rename --simulate to --dry-run
a680dd7 
- this makes it more consistent with ic-admin
- it's backwards compatible since the old arguments are still accepted
@sasa-tomic sasa-tomic requested a review from a team as a code owner June 20, 2024 10:19
pietrodimarco-dfinity
pietrodimarco-dfinity approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@sasa-tomic sasa-tomic merged commit 2eae860 into main Jun 20, 2024
4 checks passed
@sasa-tomic sasa-tomic deleted the sat-rename-simulate branch June 20, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleChimera LittleChimera LittleChimera approved these changes

@pietrodimarco-dfinity pietrodimarco-dfinity pietrodimarco-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sasa-tomic @LittleChimera @pietrodimarco-dfinity