feat(CI): adding job to ensure opentelemetry version #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an interesting bug that we really cannot catch... Its caused by
Update dependenciesjob (but I am 100% sure that dependabot would cause the same, and maybe has).Here is a problematic PR with the line: https://github.com/dfinity/dre/commit/1eda593b16fb3e72e6f102df708b5b69eb502bda#diff-13ee4b2252c9e516a0547f2891aa[…]a71c6d7a1e682c69be97998dfc87eL747
Here is the fix we added yesterday: https://github.com/dfinity/dre/commit/f029720988584e4a24450be4f83c439c3bf4738e#diff-13ee4b2252c9e516a0547f2891aa[…]71c6d7a1e682c69be97998dfc87eL6037
The issue is how the axum-otel-metrics works:
Axum otel metrics configures a global meter which is returned as a static variable. Since that global meter is a part of opentelemetry crate, if we have two different versions we won't see any of our custom metrics on service discovery.