feat(logs): Log noise filter #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasa-tomic
reviewed
Jun 28, 2024
rs/ic-observability/log-noise-filter-backend/src/handlers/delete.rs
Outdated
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea of this is to allow us to dinamically control which logs are filtered and which are not. Usually if something fails and developers oversee it, we end up having a lot of garbage logs.
Example:
Error removing artifact ConsensusMessageId { hash: Finalization(CryptoHash(0x4ac5e6a705e6ef9105315bb77614094d89191c2ea628f840d8cfb45eae499793)), height: 69300676 } Error removing artifact ConsensusMessageId { hash: NotarizationShare(CryptoHash(0xd0bfec66884cd9ec698fb91e1ca709fedf3a8365a81ac24fc2aaea4dd6a7b291)), height: 69301396 } Error removing artifact ConsensusMessageId { hash: NotarizationShare(CryptoHash(0xd0bfec66884cd9ec698fb91e1ca709fedf3a8365a81ac24fc2aaea4dd6a7b291)), height: 69301396 } Error removing artifact ConsensusMessageId { hash: Finalization(CryptoHash(0x95ba5f5ed8aae64a4d99d1e6317c03154f25c69f8a0561c19cc80ad388adde56)), height: 69300677 } Error removing artifact ConsensusMessageId { hash: NotarizationShare(CryptoHash(0xb0237e7d8f07e69548ef7368319d90a4647486799fbece19a9d3e3c66e6bf6f6)), height: 69301397 } Error removing artifact ConsensusMessageId { hash: Finalization(CryptoHash(0x27725112e68c94ee48ba7bf62e582156f79d3027bee7182196b3a55a1c6a8699)), height: 69300678 } Error removing artifact ConsensusMessageId { hash: Finalization(CryptoHash(0xbf2c529025ed93a2cf8bd98a5452285fd9d286f16b7e4ee291efcf3d97bac4ad)), height: 69300677 } Error removing artifact ConsensusMessageId { hash: NotarizationShare(CryptoHash(0xe72cfd3a71386f5fbf7e8b22e44154fd0b11087b191bcd1670272ba9042dc2aa)), height: 69301397 }These logs will be sampled and allowed through at much lower rate.