Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: panic in sync pod cron and terminal not opening fix #5603

Merged
merged 4 commits into from
Aug 2, 2024
Merged

feat: panic in sync pod cron and terminal not opening fix #5603

merged 4 commits into from
Aug 2, 2024

Conversation

prkhrkat
Copy link
Contributor

@prkhrkat prkhrkat commented Aug 1, 2024 •
edited
Loading

Description

Fixes #5606

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@prkhrkat prkhrkat changed the title panic in sync pod cron feat: panic in sync pod cron Aug 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@prkhrkat prkhrkat changed the title feat: panic in sync pod cron feat: panic in sync pod cron and terminal not opening fix Aug 2, 2024
@prkhrkat prkhrkat merged commit 644ed2e into main Aug 2, 2024
11 of 12 checks passed
@prkhrkat prkhrkat deleted the nil-check-handle branch August 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: We are not able to open the terminal of cluster in CD
2 participants
@prkhrkat @nishant-d