Implementing a setting cache #19
Conversation
ghstack-source-id: fdf297412b4269faa6477276e29681731bbb730b Pull Request resolved: #19
ghstack-source-id: 6eb38c1dc3680979c2b0d194bc98d999987d9d8d Pull Request resolved: #19
ghstack-source-id: 8ebbe2102e6a91674f9c3efa40592b84eff5d246 Pull Request resolved: #19
ghstack-source-id: 763034e39c6dde58d8a6f64e5d8559072d1ebda7 Pull Request resolved: #19
| /// the failed Result. However, the value will get refetched on the next read | ||
| /// attempt (even if it didn't exceed the TTL). | ||
| /// 4. Cache evictions happen in the background in a separate thread pool. | ||
| pub struct ProjectSetting<V, F> { |
There was a problem hiding this comment.
Should this be plural instead, i.e. ProjectSettings? The current name implies that users can get an individual setting for a given project.
Additionally, I wonder why is this generic over the value type if this has a single purpose of caching project settings?
There was a problem hiding this comment.
The current name implies that users can get an individual setting for a given project.
It is actually exactly that. As of now, there's no entity called "project settings". My idea was to keep them disaggregated such that if you want to get only the project status and not the project notification settings you can do that. That's why it's generic over the value. The value here will be the piece of the setting that you'll fetch from the project, and the fetcher will be the lambda that gets a metadata client and calls the corresponding metadata API on it.
type NotificationSettings = ProjectSetting<ProjectNotificationSetting, Fn(&ProjectId, &MetadataClient) -> ProjectNotificationSetting>;
type ProjectStatus = ProjectSetting<ProjectStatus, Fn(&ProjectId, &MetadataClient) -> ProjectStatus>;
Hope that makes sense.
There was a problem hiding this comment.
Interesting approach.
ghstack-source-id: c906f41fd517a0021667280bf1bed438bf93e9e2 Pull Request resolved: #19
ghstack-source-id: c906f41fd517a0021667280bf1bed438bf93e9e2 Pull Request resolved: #19
MohamedBassem
dismissed
AhmedSoliman’s stale review
The base branch was changed.
MohamedBassem
force-pushed
the
gh/MohamedBassem/1/head
branch
from
d3cd63e
to
b0a8bc7
Compare
ghstack-source-id: c906f41fd517a0021667280bf1bed438bf93e9e2 Pull Request resolved: #19
MohamedBassem
force-pushed
the
gh/MohamedBassem/1/head
branch
from
b0a8bc7
to
05feb99
Compare
Implementing a setting cache
ghstack-source-id: c906f41fd517a0021667280bf1bed438bf93e9e2
Pull Request resolved: #19