Skip to content

Commit

Permalink
tools/statsnoop: bring back the syscall__ prefix
Browse files Browse the repository at this point in the history
fn_name of a syscall should start with "syscall__".

See
https://github.com/iovisor/bcc/blob/v0.28.0/src/cc/frontends/clang/b_frontend_action.cc#L818

Without the patch, file names will not be printed.

Fixes: c743fcb ("tools/statsnoop: Add some stat() variants (iovisor#4367)")

Signed-off-by: Jian Wen <[email protected]>
  • Loading branch information
wenjianhn authored and yonghong-song committed Jul 10, 2023
1 parent 4f91c89 commit 18b00a9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tools/statsnoop.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@
return 0;
};
int stat_entry(struct pt_regs *ctx, const char __user *filename)
int syscall__stat_entry(struct pt_regs *ctx, const char __user *filename)
{
return trace_entry(ctx, filename);
}
int statx_entry(struct pt_regs *ctx, int dfd, const char __user *filename)
int syscall__statx_entry(struct pt_regs *ctx, int dfd, const char __user *filename)
{
return trace_entry(ctx, filename);
}
Expand Down Expand Up @@ -129,9 +129,9 @@ def try_attach_syscall_probes(syscall):
syscall_fnname = b.get_syscall_fnname(syscall)
if BPF.ksymname(syscall_fnname) != -1:
if syscall == "statx":
b.attach_kprobe(event=syscall_fnname, fn_name="statx_entry")
b.attach_kprobe(event=syscall_fnname, fn_name="syscall__statx_entry")
else:
b.attach_kprobe(event=syscall_fnname, fn_name="stat_entry")
b.attach_kprobe(event=syscall_fnname, fn_name="syscall__stat_entry")
b.attach_kretprobe(event=syscall_fnname, fn_name="trace_return")

try_attach_syscall_probes("stat")
Expand Down

0 comments on commit 18b00a9

Please sign in to comment.