Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hostmanager as provisioner #9

Merged

Conversation

vStone
Copy link
Contributor

@vStone vStone commented May 2, 2013

Allows using hostmanager as a provisioner.
I needed this to make sure the hosts file was updated before running my provisioning scripts.

@smdahlen
Copy link
Contributor

smdahlen commented May 2, 2013

@vStone I like the concept. Question -- why did you provide the configuration option for a provider?

@vStone
Copy link
Contributor Author

vStone commented May 2, 2013

It seems more... complete. I hope that in the future we will be able to use provider = :all or something of the kind.
Note, it should be easy enough to strip out for now if you would prefer that.

@smdahlen
Copy link
Contributor

smdahlen commented May 2, 2013

@vStone At the moment, it appears a user will always have to specify the backing provider of the machine. I would prefer to stay consist with the action hook and command logic which looks for other active machines with the same backing provider of the current machine. If you wouldn't mind modifying your request (by removing the provider config option), I'll go ahead and merge.

Over the next few months, we can watch how Vagrant core evolves its support for providers.

@vStone
Copy link
Contributor Author

vStone commented May 2, 2013

This should do the trick.

smdahlen added a commit that referenced this pull request May 2, 2013
@smdahlen smdahlen merged commit 8adc104 into devopsgroup-io:master May 2, 2013
@smdahlen
Copy link
Contributor

smdahlen commented May 2, 2013

Thanks. I will go ahead and bump the version and push out an updated gem.

@vStone vStone deleted the feature/hostmanager-as-provisioner branch May 2, 2013 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants