Support Cygwin and MinGW on Windows. Fixes #24

[tpbrown]

Use ENV['SystemRoot'] to determine if we're running on Windows (vs ENV[['OS']).
Also ensure we use ENV['WINDIR'] to correctly locate the hosts file.

You'll still need the hosts file to have permissions allowing modifications, or run Vagrant as an administrator.

[smdahlen]

@tpbrown Interested in managing this project (with possibly a few others)? I'm tied up for the next few months, and will not find to appropriately review pull requests.

[tpbrown]

@smdahlen Interested, yes. Available, nope. I'm tied up too :-/

I can harass a few co-workers that may have more time though. :)

[smdahlen]

Ha. Thanks.

On Mon, Nov 11, 2013 at 5:34 PM, Tim Brown [email protected] wrote:

@smdahlen https://github.com/smdahlen Interested, yes. Available, nope.
I'm tied up too :-/

I can harass a few co-workers that may have more time though. :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/49#issuecomment-28246734
.

[kevburnsjr]

+1 Please help us wintards

[bdcribbs]

I can't easily verify this patch since I'm in OSX. (It looks like this patch should not affect posix systems, but I have not tested that locally). Out of curiosity, what does ENV['OS'] report in a Cygwin environment?

Hopefully @pbitty is able to confirm and merge this one.

[kevburnsjr]

Not sure about cygwin, I'm using msysgit which is MINGW32_NT-6.1

[bdcribbs]

Ok, Thanks KevBurnsJr. This patch looks good to me, but I'll still defer to our more Window's savvy maintainer to confirm and merge it in. In either case, I expect it'll be in the next gem release.

[pbitty]

Thanks @tpbrown.

Using SystemRoot definitely works. However, it seems you can detect windows using RbConfig, which doesn't depend on environment variables. Something like:

RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/

I got it from this Stackoverflow answer, and Vagrant's code does something similar.

The nice thing using RbConfig is that the host_os value is hard-coded at build-time so it's "always legit". :) (Take a lot at rbconfig.rb somewhere under your Ruby's lib directory and you'll see what I mean.)

Are you up for changing this? I'm happy to do it otherwise.

[pbitty]

I think I'm over-complicating this. This change works and should fix the issue in cygwin.

I am testing the 'rbconfig' way in pull #48.

@tpbrown, would you be up for helping me test it? For me, it triggers the UAC prompt if I'm not running vagrant as admin.