Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide aliases for host names and configuration options validation #4

Merged
merged 2 commits into from
Apr 17, 2013

Conversation

nagas
Copy link
Contributor

@nagas nagas commented Apr 17, 2013

add simple implementation of host aliases entries (new hostmanager.aliases configuration option)
add configuration options vaidation (only when have been set)

@smdahlen
Copy link
Contributor

Have you had a chance to test this in a multi-vm Vagrantfile?

@nagas
Copy link
Contributor Author

nagas commented Apr 17, 2013

Yes, I had.
Please take a look at result: https://gist.github.com/nagas/5404211
and Vagrantfile itself: https://gist.github.com/nagas/5404239

@smdahlen
Copy link
Contributor

Great. Looks good. I'll go ahead and merge. After I incorporate the config
validation, I'll bump the release.

On Wed, Apr 17, 2013 at 9:21 AM, Mirosław Nagaś [email protected]:

Yes, I had.
Please take a look at result: https://gist.github.com/nagas/5404211
and Vagrantfile itself: https://gist.github.com/nagas/5404239


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-16504970
.

smdahlen added a commit that referenced this pull request Apr 17, 2013
provide aliases for host names and configuration options validation
@smdahlen smdahlen merged commit 9c984b6 into devopsgroup-io:master Apr 17, 2013
@nagas
Copy link
Contributor Author

nagas commented Apr 17, 2013

Could you please correct my changes to README in this branch? I just forgot to do so and they look awful :/

@smdahlen
Copy link
Contributor

Yup, I can take care of that.

On Wed, Apr 17, 2013 at 9:27 AM, Mirosław Nagaś [email protected]:

Could you please correct my changes to README in this branch? I just
forgot to do and they look awful :/


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-16505265
.

@nagas
Copy link
Contributor Author

nagas commented Apr 17, 2013

Thank you for a great job! Hostmanager rocks in my environment :D

@smdahlen
Copy link
Contributor

Your welcome. The README file has been updated and I pushed a new version
to rubygems with your commits (v0.1.1). I'm going to hold on the config
validation check for the moment -- after investigation, the refactoring
will take a bit longer than the time I have available for the next few days.

Thanks again for your commits.

On Wed, Apr 17, 2013 at 9:33 AM, Mirosław Nagaś [email protected]:

Thank you for a great job! Hostmanager rocks in my environment :D


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-16505586
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants