fixed windows compatibility issues for the hosts file #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i have added a 'if windows' for the update_host method, to deal with a windows host machine. sometimes i had an error on line 17, because the file was no longer there (maybe mv removed it?), so i just added a exception block to catch it. it does nothing, but now it is working for me.
|
@itaymendel Thanks. I'll go ahead and merge. Unfortunately, I cannot test since I do not have a copy of Windows. |
smdahlen
added a commit
that referenced
this pull request
Aug 29, 2013
fixed windows compatibility issues for the hosts file
|
cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi Shawn, great job on this plugin :)
I found some windows compatibility issue that i fixed.
the hostsfile::update_host didn't deal with a windows based environment, so i added a small if statement.
another thing, that might be a windows thing, but i have no idea, because on a single-vm it worked, but when i added more VMs, it started to happen... in hostfile::update_guest i got error on FileUtils.rm that says that there is no file/directory on the /etc/hosts file. so i added a rescue statement.
i forgot to add it to the request, but the en.yml file need to be updated:
update_host: "Updating /etc/hosts file on host machine (password may be required, on windows run cmd in administrator mode)..."