Fix host file management for Linux and Windows hosts #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (correctly this time!) resolves #232 #228 #231 and #229.
My initial commit fixed windows, but broke linux and I didn't catch it during testing as I was only running hostmaster on the windows box. This morning I realized the breakage on the linux side and fixed that. Rather than creating /tmp/hosts for linux hosts I opted to just put the
hosts.#{machine.name}
directly in /tmp as on windows we're already moving it, and adding the rm for linux hosts.I tested with 3 nodes several times to ensure this worked as expected:
RHEL7
CentOS 6
Windows 2012