Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check explicitly if hostmanager.ignore_private_ip is set to true #2

Merged
merged 1 commit into from
Apr 17, 2013

Conversation

nagas
Copy link
Contributor

@nagas nagas commented Apr 17, 2013

As vagrant hostmanager (in contrary to eg. vagrant provision) doesn't implicate config finalization and validation, hostmanager.ignore_private_ip is never set to false in such a case. It is just an object

class Config
# [...]
  UNSET_VALUE = Object.new

and the below statement

unless machine.config.hostmanager.ignore_private_ip

results in false, causing the plugin to ignore private ip when the option is not set at all.

It would be probably better to force vagrant hostmanager to finalize! and validate the configuration, but I couldn't figure it out yet.

@smdahlen
Copy link
Contributor

Thanks for PR. I'll go ahead and merge. With the regards to config validation, I have that on my list to do. The command needs to call an action stack using the action runner with ConfigValidate included.

smdahlen added a commit that referenced this pull request Apr 17, 2013
check explicitly if hostmanager.ignore_private_ip is set to true
@smdahlen smdahlen merged commit c94b1f8 into devopsgroup-io:master Apr 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants