Improving Windows support for writing hosts file entries. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mentioned in Issue #171 before writing to the host file, convert the line endings. Requires Ruby 1.9 |
|
This was not working consistently for me - will need to further test and adapt. |
|
Strange, it was for me. What environment are you using? Was it happening in a particular way? What did you experience? |
|
There there any progress on testing on this one? We want to use this but we can't without this bug being patched |
|
@tschirmer what version of Windows are you using? |
|
@seth-reeser Windows 10 |
|
This will only work for the host, we'll be releasing a solution that will write CRLF to both the host and guest where appropriate. |
|
This has been resolved with v1.8.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving Windows support for writing to the host files by handling the line endings before writing the file.