New hosts os hosts file

[b2jrock]

(re-did this branch to make it easier to review)

This set of changes was made to manage hosts file entries on the host machine. This is so that you can use the hostnames to connect to your local boxes.

As part of this, I changed it so that we actually fetch the existing hosts file from the guest machines and add to it rather than overwriting.

Keywords added: hostmanager.manage_local = true
Manage local hosts file

Caveats:

Assumes that you need sudo to modify your local /etc/hosts file, I am planning on making this a configuration parameter in the near future.
It's assuming your hosts file is /etc/hosts, so it won't work with windows.

[smdahlen]

@b2jrock Sorry, running behind. I'll look to review and merge tomorrow.

[smdahlen]

@b2jrock After some testing, it appears that destroying a single machine within a multi-machine environment removed all entries in the hosts file on other guest machines. This does not occur on the host. I'm looking further now. If you have a fix, let me know, and I will re-pull from your branch.

[b2jrock]

That should remove only the single entry for that machine on the other
machines. I will attempt to reproduce that this morning.
On Jun 17, 2013 6:49 AM, "Shawn Dahlen" [email protected] wrote:

@b2jrock After some testing, it appears that destroying a single machine
within a multi-machine environment removed all entries in the hosts file on
other guest machines. This does not occur on the host. I'm looking further
now. If you have a fix, let me know, and I will re-pull from your branch.

—
Reply to this email directly or view it on GitHub.

[b2jrock]

Repro'd and found the bug, it seems that the machine id is coming through
as empty in certain cases, so the regex is matching everything when it goes
to delete.

Fix forthcoming.

Brian

On Mon, Jun 17, 2013 at 9:44 AM, Brian J [email protected] wrote:

That should remove only the single entry for that machine on the other
machines. I will attempt to reproduce that this morning.
On Jun 17, 2013 6:49 AM, "Shawn Dahlen" [email protected] wrote:

@b2jrock After some testing, it appears that destroying a single machine
within a multi-machine environment removed all entries in the hosts file on
other guest machines. This does not occur on the host. I'm looking further
now. If you have a fix, let me know, and I will re-pull from your branch.

—
Reply to this email directly or view it on GitHub.

[b2jrock]

Looking pretty good, I ran the following tests -- maybe we can document/automate this:

• Create 3 machines with manage_local on
  -- Ensure that entries are added to local hosts file and hosts file on each guest, and that localhost entry is correct
• Remove an entry from local hosts file, and one of the guests
  -- Run 'vagrant fhostmanager'
  -- ensure that the entry is recreated in both places.
• run 'vagrant destroy machine' for any machine
  -- ensure that the machine entry is removed from all the machines and host machine
• run 'vagrant destroy'
  -- ensure all machines are deleted from host hosts file

[smdahlen]

I've pulled your update. I'll modify the acceptance test to automate the approach you outlined.