Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the scoped config block when running as a provisioner instead of trying to get the global config #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Roguelazer
Copy link

We have separate hostmanager configuration stanzas for different Providers; right now, if you set a hostmanager config on a provider's override block, it is completely ignored.

This patch fixes it.

I'm not sure if there's some subtle reason that I missed; if so, please let me know and we can brainstorm some other way to fix it.

Example config:

Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
  config.vm.box = "some-box-name"
  config.hostmanager.ip_resolver = default_proc_used_on_default_provisioner

  config.vm.provider "virtualbox" do |vb, override|
    override.hostmanager.ip_resolver = some_other_proc
  end
end

@Roguelazer
Copy link
Author

This is still preventing hostmanager from working on Vagrantfiles with provider overrides.

@seth-reeser
Copy link
Member

I will investigate and test this in the next few days and release if appropriate. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants