Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #108, add a flag to manage guest hosts file. #125

Merged

Conversation

damienjoldersma
Copy link
Contributor

No description provided.

@cjsaylor
Copy link

cjsaylor commented Jan 7, 2015

👍 This would be very useful!

@seth-reeser
Copy link
Member

Hello, I've taken over this project. Can you please provide a use case for this? I haven't run into this need before.

@damienjoldersma
Copy link
Contributor Author

Greetings :) My use case was basically very similar to what @tknerr originally posted in #108: basically, I have my guests hosts file managed via chef but find it necessary to manually update my host's host file (especially for doing ssl cert testing on fqdn that has to match the host and ip). And I think I was doing something else to the hosts file that was maybe getting overwritten. Honestly, it's been a little while, and I have just gotten used to manually managing my host's host file after all, but maybe someone else would find this useful. However, after reviewing my code, I can see that I defaulted this plugin to be disabled, so not actually using atm.

Cheers!

@HadesArchitect
Copy link

Any updates? We also need this option. Thanks!

@jdrago999
Copy link

Ooooooooooooyyyy what's the holdup, mate??

@seth-reeser
Copy link
Member

I have vetted this and will release within the coming days.

seth-reeser added a commit that referenced this pull request Feb 11, 2016
Fix for issue #108, add a flag to manage guest hosts file.
@seth-reeser seth-reeser merged commit 3b840be into devopsgroup-io:master Feb 11, 2016
@damienjoldersma damienjoldersma deleted the feature/manage-guest-flag branch February 11, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants