Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: azure (original, original-wordmark, plain, plain-wordmark) #816

Merged
merged 5 commits into from
Aug 20, 2021

Conversation

ThomasMoran
Copy link
Contributor

@Thomas-Boi Thomas-Boi added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 19, 2021
@github-actions

This comment has been minimized.

@Thomas-Boi
Copy link
Member

Overall, the icons look good. However, I don't know why the wordmark version is having weird artifacts like that.

Can you try splitting the text into a separate <path> than the A? I'm not sure if it will work but I can't think of any other reason.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look great. Good job, @ThomasMoran! 😄👍
Just one thing: please try to remove that on the SVG.

image

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 19, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome work, @ThomasMoran! You did great to be your first contribution here. We hope you keep contributing! Thank you! 😄👍🎉

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! You did a great job fixing the SVG. I'll merge this icon in now.

@Thomas-Boi Thomas-Boi merged commit 67b2399 into devicons:develop Aug 20, 2021
@Thomas-Boi
Copy link
Member

This PR will now be used as part of our docs.

Bug: Icon version contains strange artifacts when built using Icomoon.

Fix: Before, the "A" logo and the word "Azure" were joined as one <path> object. I suggested that the contributor split them into two separate path objects: one for the "A" and one for the "Azure".

Here is what the icon looks like before the fix:
image

Here is what it looks like after the fix:
image

This was referenced Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants