-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: azure (original, original-wordmark, plain, plain-wordmark) #816
Conversation
This comment has been minimized.
This comment has been minimized.
Overall, the icons look good. However, I don't know why the wordmark version is having weird artifacts like that. Can you try splitting the text into a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons look great. Good job, @ThomasMoran! 😄👍
Just one thing: please try to remove that on the SVG.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: You can click on the pictures and zoom on them if needed. The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awesome work, @ThomasMoran! You did great to be your first contribution here. We hope you keep contributing! Thank you! 😄👍🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! You did a great job fixing the SVG. I'll merge this icon in now.
This PR will now be used as part of our docs. Bug: Icon version contains strange artifacts when built using Icomoon. Fix: Before, the "A" logo and the word "Azure" were joined as one |
Addressing #599
Using the new Azure logo https://azure.microsoft.com/en-gb/blog/a-fluent-new-look-for-the-azure-icon/