Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized SVG using SVGO #597

Merged
merged 8 commits into from
May 15, 2021
Merged

Optimized SVG using SVGO #597

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abbf307
Added script to optimize svgs
Thomas-Boi May 3, 2021
9fb968a
Updated the svgs using svgo
Thomas-Boi May 4, 2021
46ae46b
Made the optimize svg script into a workflow
Thomas-Boi May 5, 2021
7da8176
Added npm install step
Thomas-Boi May 6, 2021
3a9febe
Change the env variable bug
Thomas-Boi May 6, 2021
2fab26a
Clean up and updated check svg
Thomas-Boi May 6, 2021
fda14ca
Change label name
Thomas-Boi May 6, 2021
f5cb3c2
Merge branch 'develop' into thomas/feature/updateSvgWorkflow
Thomas-Boi May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'develop' into thomas/feature/updateSvgWorkflow
  • Loading branch information
@Thomas-Boi
Thomas-Boi committed May 14, 2021
commit f5cb3c2fc7ce3bde7110a4c84ba49b181237bf53
6 changes: 3 additions & 3 deletions .github/scripts/check_svgs_on_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ def check_svgs(svg_file_paths: List[Path]):
if root.get("viewBox") != "0 0 128 128":
err_msg.append("-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg")

if root.get("x") is not None:
err_msg.append("-unneccessary 'x' attribute in svg element -> Remove it")
if root.get("x") is not None:
err_msg.append("-unneccessary 'x' attribute in svg root element -> Remove it")

if root.get("y") is not None:
err_msg.append("-unneccessary 'y' attribute in svg element -> Remove it")
err_msg.append("-unneccessary 'y' attribute in svg root element -> Remove it")

style = root.findtext(f".//{namespace}style")
if style != None and "fill" in style:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.