Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python wordmark icon #103

Merged
merged 3 commits into from
May 15, 2021
Merged

Fix python wordmark icon #103

merged 3 commits into from
May 15, 2021

Conversation

Kartstig
Copy link
Contributor

@iamclaytonray
Copy link
Contributor

Hey @Kartstig - In #93, you mentioned:

I have gotten the Python icon to work, but it doesn't release certain backgrounds, casing other subsequent icons to be colored yellow.

Is that the case with this fixed version? I'm not sure what you mean here. Thanks!

@Kartstig
Copy link
Contributor Author

Oh it's been a while. Let me look at this again and get back to you

@Kartstig
Copy link
Contributor Author

What I was referring to in the issue was that master had an SVG such that it didn't release the colors, so when you changed them, it affected everything else.

e.g. If you added the python icon, followed by another icon, it would color the proceeding icon yellow from the python icon

Here's the version I have provided:
image

I just verified that this new image has resolved the issue by allowing the update of individual paths inside the SVG without breaking the other paths:
image

image

image

One other thing to note about this update is that it changes the alignment of the words. "python" is now below the icon. I think this is more consistent with the other icons, and makes alignment easier on the front-end.

@Kartstig
Copy link
Contributor Author

@iamclaytonray let me know if you need any updates or clarification. Thanks!

@iamclaytonray
Copy link
Contributor

@Kartstig - ah, I see! Sorry, been super slammed with work. I'll try to get back to this tonight but if not, tomorrow morning/afternoon. Thanks again!

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
@amacado amacado linked an issue Jun 8, 2020 that may be closed by this pull request
Python SVG Icon not work #93
Closed
@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Kartstig
Copy link
Contributor Author

Kartstig commented Jan 6, 2021

@iamclaytonray i'm revisiting my PRs here. any chance we can get this merged?

@Kartstig Kartstig mentioned this pull request Jan 6, 2021
Closed
@amacado
Copy link
Member

amacado commented Jan 7, 2021

Let's wait for #93 (comment) so we get the feedback if the issue is fixed.

amacado
amacado previously requested changes Jan 7, 2021
View reviewed changes
icons/python/python-original-wordmark.svg Outdated Show resolved Hide resolved
@amacado amacado changed the base branch from master to develop January 7, 2021 00:06
@Altijd-youri
Copy link

The python foundation has two svg of their logo on the website. Why not strip their svg and add the word 'python' below?

Python logo from Python foundation
From https://www.python.org/community/logos/

@amacado amacado added the stale For PRs that haven't had any activity for a while and old issues label Feb 23, 2021
Thomas-Boi
Thomas-Boi approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the file is not optimized since the bot is failing for some reason (can't checkout repo), I'll accept the PR and optimize it manually.

@Thomas-Boi Thomas-Boi dismissed amacado’s stale review May 15, 2021 23:42

Optimize SVG will remove the enable-background where possible. See here

@Thomas-Boi Thomas-Boi merged commit a5d5b00 into devicons:develop May 15, 2021
@Thomas-Boi
Copy link
Member

Thanks @Kartstig for fixing this. Sorry for taking a long time to get around to this PR. Life has been busy 😅

@Thomas-Boi Thomas-Boi mentioned this pull request May 15, 2021
Closed
@Kartstig Kartstig deleted the update-python branch May 16, 2021 15:01
@Thomas-Boi Thomas-Boi mentioned this pull request May 24, 2021
Merged
Thomas-Boi added a commit that referenced this pull request Jun 13, 2021
@Thomas-Boi @Kartstig
@EnisMulic @Panquesito7 @amacado @dependabot @jeovazero @mattkoskela @maltejur @AtomToast @Utkarsh1504 @mjlabe @jpdevries @aueda @rjlopezdev @mariaavideva @cseelus @ben-hampson @SaketKothari @github-actions
Release v2.12.0 (#680)
5ec6bfc 
* Add arduino icon

* Update all icon types

* Add to icon registry

* Update arduino icons

* Update arduino icons

* Remove vscode folder

* Update icons/arduino/arduino-original-wordmark.svg

* Update icons/arduino/arduino-original.svg

* Update icons/arduino/arduino-plain-wordmark.svg

* Update icons/arduino/arduino-plain.svg

* enhance guidelines for drafting a new release

* Bump ini from 1.3.5 to 1.3.8 (#562)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: Thomas Bui <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Clemens Bastian <[email protected]>

* Added a section for common bugs in the CONTRIBUTING (#563)

* new icon: nixos (original, original-wordmark, plain, plain-wordmark) (#564)

* new icon: nixos (original, original-wordmark, plain, plain-wordmark)

* icon nixos: optimize the svgs

* icon nixos: add newline at end of svgs

* icon nixos: remove extra line

* feat: Added perl icons

* chore: Simplify svg files

* fix: size fixes

* fix: Removed aliases from json

* Add aliases (fixes the script)

* Update devicon.json

* Update devicon.json

* fix: Renamed icons

* fix: Cleaned up svg files and ran svg opimizer

* Delete arduino-plain-wordmark.svg

Deleted the faulty svg

* Add Icomoon arduino-plain-wordmark.svg

* Rename arduino-plain-workmark.svg to arduino-plain-wordmark.svg

* Update devicon.json

Co-authored-by: David Leal <[email protected]>

* Script upgrades and updated CONTRIBUTING.md and README.md (#576)

* Updated README and CONTRIBUTING

* Added check for devicon object when peeking

* Added PR template

* Added a script to create release messages

* Updated CONTRIBUTING about new script

* Update .github/PULL_REQUEST_TEMPLATE/new_icon.md

Co-authored-by: David Leal <[email protected]>

* Update .github/scripts/build_assets/arg_getters.py

Co-authored-by: David Leal <[email protected]>

* Update .github/workflows/get_release_message.yml

Co-authored-by: David Leal <[email protected]>

* Update gulpfile.js

Co-authored-by: David Leal <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE/new_feature.md

Co-authored-by: David Leal <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE/new_feature.md

Co-authored-by: David Leal <[email protected]>

* Added a way for peek bot to comment error

* Update CONTRIBUTING.md

Co-authored-by: Clemens Bastian <[email protected]>

* Update .github/scripts/get_release_message.py

Co-authored-by: Malte Jürgens <[email protected]>

* Update .github/scripts/get_release_message.py

Co-authored-by: Malte Jürgens <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE/new_feature.md

Co-authored-by: David Leal <[email protected]>

* Clean up and updated CONTRIBUTING

* Updated CONTRIBUTING

* Add set up steps for release message workflow

* Refactored peek workflow

* Added requests library

* Reformat devicon object error messages

Co-authored-by: David Leal <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: Malte Jürgens <[email protected]>

* new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)

* new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)

* resized svgs

* cleaned up svgs

* compressed svgs and updated viewboxes

* new icon: zig (original, original-wordmark, plain-wordmark)

* Replace raw.githubusercontent.com with jsdelivr (#586)

Co-authored-by: Clemens Bastian <[email protected]>

* recommended svg fixes

* Clean up and CONTRIBUTING upgrade (#595)

* Updated CONTRIBUTING

* Clean up various scripts (no functional changes)

* Update CONTRIBUTING.md

Co-authored-by: Clemens Bastian <[email protected]>

* Change icons to use devicon in README and CONTRIBUTING

* Add optimize-bot into CONTRIBUTING.md

* Update CONTRIBUTING.md

Co-authored-by: David Leal <[email protected]>

* Update README.md

Co-authored-by: David Leal <[email protected]>

* Update README.md

Co-authored-by: David Leal <[email protected]>

* Change release message step name

* Update CONTRIBUTING.md

Co-authored-by: David Leal <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: David Leal <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: David Leal <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: David Leal <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: David Leal <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: David Leal <[email protected]>

* Changed all 'svg' to "SVG"

Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: David Leal <[email protected]>

* Optimized SVG using SVGO (#597)

* Added script to optimize svgs

* Updated the svgs using svgo

* Made the optimize svg script into a workflow

* Added npm install step

* Change the env variable bug

* Clean up and updated check svg

* Change label name

* Fix python wordmark icon (#103)

* Fix python wordmark icon

* Update icons/python/python-original-wordmark.svg

Co-authored-by: Clemens Bastian <[email protected]>

Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: Thomas Bui <[email protected]>

* New icon: raspberrypi (original, original-wordmark, line, line-wordmark) (#609)

* Add rpi icon

* Add original. Remove `enable-background`. Fix font colors

* Add icons to list

* Fix formatting

* Add official RPi logo + eps. Update svg and font

* Updated raspberry icons

* Optimized the SVGs

Co-authored-by: Herman Singh <[email protected]>
Co-authored-by: Thomas-Boi <[email protected]>

* New icon: tailwindcss (plain) (#610)

* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

* Create README.md

* Add files via upload

* Delete README.md

* Update devicon.json

* new file added

* file added

* Delete jamstack-plain.svg

* Add files via upload

* Delete icons/jamstack directory

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <[email protected]>

* Updated and optimized python svgs (#622)

* Updated and optimized python svgs

* Update icons/python/python-original.svg

Co-authored-by: David Leal <[email protected]>

Co-authored-by: David Leal <[email protected]>

* new icon: labview (original, original-wordmark, plain, plain-wordmark) (#626)

* add labview icon (original, plain, original-wordmark, plain-wordmark)

* Updated labview svgs

Co-authored-by: Marc LaBelle <[email protected]>

* new icon: modx (original, original-wordmark, plain, plain-wordmark) (#627)

* Submitting MODX logo

MODX is a popular open source PHP CMS. Its logo is also found in
FontAwesome, seems like it would be great for it to have

* Updated devicon.json and modx svg color

* Fixed issues reported by svg-checker bot

Co-authored-by: JP DeVries <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* new icon: knockout (plain-wordmark) (#628)

* Added Knockout icon (plain workmark only)

* Updated devicon.json

Co-authored-by: Adriano Ueda <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* new icon: embeddedc (original, plain, original-wordmark, plain-wordmark) (#625)

* add embeddedc icon (original, plain, original-wordmark, plain-wordmark)

* Convert style to fill

* Remove merge error in devicon.json

Co-authored-by: Marc LaBelle <[email protected]>

* Optimize bot is now a part of the build script (#624)

Co-authored-by: Clemens Bastian <[email protected]>

* Add extra requirement in new icon pr template (#642)

* Add extra requirement in new icon pr template

* Update .github/PULL_REQUEST_TEMPLATE/new_icon.md

Co-authored-by: Clemens Bastian <[email protected]>

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: rstudio (orignal. plain) (#634)

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: phalcon (original, plain) (#635)

* Add phalcon svgs

* Change style to fill attribute

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: minitab (original, plain) (#636)

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: bulma (plain) (#638)

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: spss (original, plain) (#639)

* Add spss svgs

* Addressed svg bot's issues

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: jest (plain) (#647)

Co-authored-by: Raúl Julián López Caña <[email protected]>

* update public-upload-to-imgur action v2.2.2 (#651)

* update public-upload-to-imgur action v2.2.2

* update imgur upload action to v2.2.2

* new icon: karma (original, plain) (#646)

Co-authored-by: Raúl Julián López Caña <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* new icon: circleci (plain, plain-wordmark) (#648)

Co-authored-by: Raúl Julián López Caña <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* new icon: shopware (original, original-wordmark) (#653)

* Shopware

Adding SHopware icons

* Fixed check svgbot issues

Co-authored-by: Mariya Videva <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* new icon: salesforce (original, plain) (#654)

* SalesForce

Adding SalesForce icons

* Fixed check svg errors

Co-authored-by: Mariya Videva <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* new icon: vuestorefront (original, plain) (#655)

* vue StoreFront

vue StoreFront icons

* Update vuestorefront-plain

Co-authored-by: Mariya Videva <[email protected]>

* new icon: codecov (plain) (#649)

* Add Codecov icons (plain)

* Update codecov-plain

* Centered codecov plain

Co-authored-by: Raúl Julián López Caña <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* Add Unix icon (#659)

Co-authored-by: Clemens Bastian <[email protected]>

* Peek bot won't check whether icon is in icomoon (#657)

Co-authored-by: David Leal <[email protected]>

* new icon: magento (original, original-wordmark, line) (#652)

* Magento

Adding Magento Icon

* Fix issues reported by check svg bot

* Fixed magento line

Co-authored-by: Mariya Videva <[email protected]>

* Fix svg checker double posting comment (#660)

Co-authored-by: Clemens Bastian <[email protected]>

* Update issue and PR templates (#658)

* Update issue and PR templates

* Added icon requirements to contributing

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: David Leal <[email protected]>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: David Leal <[email protected]>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-authored-by: David Leal <[email protected]>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-authored-by: David Leal <[email protected]>

* Update .github/ISSUE_TEMPLATE/feature_request.md

Co-authored-by: David Leal <[email protected]>

* Update .github/ISSUE_TEMPLATE/icon-request.md

Co-authored-by: David Leal <[email protected]>

* Apply suggestions from code review

Co-authored-by: David Leal <[email protected]>

* Apply suggestions from code review

Co-authored-by: David Leal <[email protected]>

* Update bug_report.md

* Update .github/PULL_REQUEST_TEMPLATE/new_feature.md

Co-authored-by: David Leal <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE/new_feature.md

Co-authored-by: David Leal <[email protected]>

Co-authored-by: David Leal <[email protected]>

* new icon: godot (original, original-wordmark, plain, plain-wordmark) (#663)

* new icon: godot (original, original-wordmark, plain, plain-wordmark)

* Minor fix

Co-authored-by: Thomas Bui <[email protected]>

* new icon: vscode (original, original-wordmark, plain, plain-wordmark) (#664)

* new icon: julia (original, original-wordmark, plain, plain-wordmark) (#665)

* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

* new icon: julia (original, original-wordmark, plain, plain-wordmark)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* new icon: matlab (line) (#640)

* Add matlab-line

* Fixed issues reported by check svg bot

* optimisation for svg (#643)

Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: David Leal <[email protected]>

* new icon: crystal (original, original-wordmark) (#667)

* typo & grammar fixes in readme (#670)

* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

* Typo + grammar fixes.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* Build bot now build new SVGs in folder that were already built (#666)

* Refactor the pull request fetching code

* Refactor build script to use past PRs

* Added function to update icomoon json

* new icon: matlab (line) (#640)

* Add matlab-line

* Fixed issues reported by check svg bot

* optimisation for svg (#643)

Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: David Leal <[email protected]>

* Add better logging to icomoon_build

Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: David Leal <[email protected]>

* new icon: tailwindcss (wordmark) (#671)

* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

* added tailwindcss wordmark

* updated commit

* updated

* done

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <[email protected]>

* Minor update to CONTRIBUTING and post peek (#672)

* Fix duplicated past icons in build process (#674)

* Fixed issue with wrong name referencing from github api (#677)

* bump npm version to v2.12.0

* Built new icons, icomoon.json and devicon.css (#678)

Co-authored-by: Thomas-Boi <[email protected]>

Co-authored-by: Herman Singh <[email protected]>
Co-authored-by: Enis Mulić <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jeovazero <[email protected]>
Co-authored-by: Matt Koskela <[email protected]>
Co-authored-by: Malte Jürgens <[email protected]>
Co-authored-by: reevesba <[email protected]>
Co-authored-by: AtomToast <[email protected]>
Co-authored-by: Thomas-Boi <[email protected]>
Co-authored-by: Utkarsh Mishra <[email protected]>
Co-authored-by: Marc LaBelle <[email protected]>
Co-authored-by: JP DeVries <[email protected]>
Co-authored-by: Adriano Ueda <[email protected]>
Co-authored-by: Raúl Julián López Caña <[email protected]>
Co-authored-by: Mariya Videva <[email protected]>
Co-authored-by: Chrıs Seelus <[email protected]>
Co-authored-by: Ben Hampson <[email protected]>
Co-authored-by: Saket Kothari <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

@amacado amacado amacado left review comments

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python SVG Icon not work
5 participants
@Kartstig @iamclaytonray @Thomas-Boi @amacado @Altijd-youri