Use depends_on dependency container

[nathaliaortegaGL]

add depends_on to kibana and logstash on docker-compose.yml to prevent having to install NC and not have to keep checking for ES to start as the container will start after.

[deviantony]

Oh this looks really nice !! Did you try it? Are you sure that the kibana service will be able to detect that the elasticsearch is ready to listen on port 9200 ?

As stated in docker-compose docs: https://docs.docker.com/compose/compose-file/#/dependson

Note: depends_on will not wait for db and redis to be “ready” before starting web - only until they have been started.

Maybe Kibana 5 now have a better support to re-establish connections to elasticsearch though... I need to try this :)

[quentinfayet]

@deviantony @nathaliaortegaGL I'm currently using depends_on on a custom docker ELK stack, and everything works just fine. Kibana service waits quietly for Elasticsearch to be up and running.

[nathaliaortegaGL]

@deviantony yes, I tried it and it works fine! :)

[deviantony]

Hey ! Thanks again for the PR and sorry for my late review.

I just tested it, it works perfectly well ! It seems that Elastic managed to make logstash/kibana try to reconnect on the elasticsearch instance insteadd of shutting down.

As said in the comments, the script kibana/entrypoint.sh is now useless. We'll keep the kibana/Dockerfile with only the base image import as it may be used later to extend it easily.

I've also tested without the depends_on directives and it works too ! But we'll keep them as it make things clearer about the dependencies of the stack.

[deviantony]

You can also remove the lines 3-4 which are used to copy the entrypoint.sh script. This script has no purposes anymore, so please delete it too. We'll keep the kibana/Dockerfile with only the FROM directive.

[deviantony]

As said previously, delete the file kibana/entrypoint.sh.

[deviantony]

ping @nathaliaortegaGL

[krainboltgreene]

depends_on will (1.10) eventually use HEALTHCHECK to determine if it's actually ready, which is nice, but any "it works in correct order" here is chance.

[deviantony]

Yeap, this is indeed a good PR. Another ping @nathaliaortegaGL ?

[ernestova]

I just ping @nathaliaortegaGL internally to update her PR.

[nathaliaortegaGL]

@deviantony changes have been applied!

[deviantony]

One last update required.

[deviantony]

You also need to remove this line, otherwise it won't work.

[deviantony]

@nathaliaortegaGL one more thing needs to be updated.

[nathaliaortegaGL]

@deviantony Sorry, forgot to delete that :) It's ready now.

[deviantony]

Thanks @nathaliaortegaGL :)