Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution for connection error when running compose #461

Merged
merged 3 commits into from
Feb 25, 2020

Conversation

omerBotenski1987
Copy link
Contributor

No description provided.

@antoineco
Copy link
Collaborator

@omerBotenski1987 thanks for the suggestion. Could you please provide more context on the error you're seeing?

In general I'd avoid telling users to escalate privileges, and instead redirect them to the Docker docs, which recommend adding users to the docker Unix group on their Docker host.

@omerBotenski1987
Copy link
Contributor Author

omerBotenski1987 commented Jan 13, 2020 via email

@antoineco
Copy link
Collaborator

antoineco commented Jan 13, 2020

OK that makes sense if your user wasn't inside the group I mentioned. However, I'd recommend following the instructions at https://docs.docker.com/install/linux/linux-postinstall/ instead of giving users the false impression they need to run arbitrary commands using sudo. It is assumed that users have correctly set up their environment prior to fiddling with this project.

How about linking the page above under the "requirements" title of the README instead? For example:


Host setup

  • Docker Engine version 17.05+ and a properly configured host (add link)
  • ...

@antoineco antoineco merged commit 80bca0e into deviantony:master Feb 25, 2020
antoineco added a commit that referenced this pull request Feb 25, 2020
antoineco added a commit that referenced this pull request Feb 25, 2020
antoineco added a commit that referenced this pull request Feb 25, 2020
bleed2002 pushed a commit to bleed2002/docker-elk that referenced this pull request Feb 29, 2020
DanBrown47 pushed a commit to DanBrown47/docker-elk that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants